[fwd.hpp] add deprecations for uses of Eigen::aligned_allocator #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligator
now requires C++17, hence there is no longer any use for theEigen::aligned_allocator<T>
template class. Hence all aliases for the relevant std::vector type and use of std::allocate_shared (which takes an allocator type as argument) are useless.This PR deprecates both the typedef for
std::vector<T, Eigen::aligned_allocator<T>>
and thealigator::allocate_shared_eigen_aligned
function template, and removes all use of the later (replaced by vanillamake_shared
).