Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fwd.hpp] add deprecations for uses of Eigen::aligned_allocator #184

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

ManifoldFR
Copy link
Member

@ManifoldFR ManifoldFR commented Aug 30, 2024

aligator now requires C++17, hence there is no longer any use for the Eigen::aligned_allocator<T> template class. Hence all aliases for the relevant std::vector type and use of std::allocate_shared (which takes an allocator type as argument) are useless.

This PR deprecates both the typedef for std::vector<T, Eigen::aligned_allocator<T>> and the aligator::allocate_shared_eigen_aligned function template, and removes all use of the later (replaced by vanilla make_shared).

@ManifoldFR ManifoldFR enabled auto-merge August 30, 2024 16:04
@ManifoldFR ManifoldFR merged commit 99dac89 into devel Aug 30, 2024
35 checks passed
@ManifoldFR ManifoldFR deleted the topic/deprecate-eigen-aligned-things branch August 30, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant