Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CMAKE_INSTALL_FULL_<dir> to CMAKE_INSTALL_<dir> #122

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

abussy-aldebaran
Copy link
Contributor

@abussy-aldebaran abussy-aldebaran commented Jan 22, 2025

See CMake documentation:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

These variables shouldn't be used in install() commands as they do not work with the cmake --install command's --prefix option, or with the cpack installer generators.

In pratice, this caused wrong IMPORTED_LOCATION_ in the generated proxsuite-nlpTargets-release.cmake, e.g.

set_target_properties(proxsuite-nlp::proxsuite-nlp PROPERTIES
  IMPORTED_LOCATION_RELEASE "/usr/lib/libproxsuite-nlp.so.0.10.0"
  IMPORTED_SONAME_RELEASE "libproxsuite-nlp.so.0.10.0"
  )

instead of

set_target_properties(proxsuite-nlp::proxsuite-nlp PROPERTIES
  IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/libproxsuite-nlp.so.0.10.0"
  IMPORTED_SONAME_RELEASE "libproxsuite-nlp.so.0.10.0"
  )

See CMake documentation:
  https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

These variables shouldn't be used in install() commands as they
do not work with the cmake --install command's --prefix option,
or with the cpack installer generators.
Copy link
Member

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jorisv jorisv merged commit 1413ff0 into Simple-Robotics:devel Jan 23, 2025
17 of 18 checks passed
@ManifoldFR
Copy link
Member

Thanks @abussy-aldebaran ! I'll make an official v0.10.1 release with this patch and the other changes since November.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants