MODsuits (Port From Goob #1242) #1640

Erisfiregamer1 · 2025-01-23T01:22:22Z

Description

Ports MODsuits from Goobstation PR Goob-Station/Goob-Station#1242. The PR author has confirmed that he is okay with me doing this.

TODO

Media

Modsuit crafting

Desktop.2024.12.23.-.10.36.29.03.DVR.-.Trim.mp4

Modsuit sealing

Desktop.2024.12.23.-.10.56.52.05.DVR.-.Trim.mp4

Changelog

🆑

add: Modsuits have been ported from Goobstation!

github-actions · 2025-01-23T01:22:58Z

RSI Diff Bot; head commit d89185d merging into 0e309db
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Goobstation/Actions/modsuit.rsi

State	Old	New	Status
activate-ready			Added
activate			Added

Resources/Textures/_Goobstation/Clothing/Back/Modsuits/standard.rsi

State	Old	New	Status
control-sealed			Added
control			Added
equipped-BACKPACK-sealed			Added
equipped-BACKPACK			Added

Resources/Textures/_Goobstation/Clothing/Hands/Modsuits/standard.rsi

State	Old	New	Status
equipped-HAND-sealed			Added
equipped-HAND			Added
gauntlets-sealed			Added
gauntlets			Added

Resources/Textures/_Goobstation/Clothing/Head/Modsuits/standard.rsi

State	Old	New	Status
equipped-HEAD-sealed			Added
equipped-HEAD			Added
helmet-sealed			Added
helmet			Added

Resources/Textures/_Goobstation/Clothing/OuterClothing/Modsuits/standard.rsi

State	Old	New	Status
chestplate-sealed			Added
chestplate			Added
equipped-OUTERCLOTHING-sealed			Added
equipped-OUTERCLOTHING			Added

Resources/Textures/_Goobstation/Clothing/Shoes/Modsuits/standard.rsi

State	Old	New	Status
boots-sealed			Added
boots			Added
equipped-FEET-sealed			Added
equipped-FEET			Added

Resources/Textures/_Goobstation/Interface/Alerts/modpower.rsi

State	Old	New	Status
modpower0			Added
modpower1			Added
modpower2			Added
modpower3			Added
modpower4			Added
modpower5			Added

Resources/Textures/_Goobstation/Objects/Specific/Robotics/modsuit_parts.rsi

State	Old	New	Status
boots			Added
chestplate			Added
gauntlets			Added
helmet			Added
mod-core-standard			Added
shell-boots			Added
shell-chestplate			Added
shell-core-secured			Added
shell-core			Added
shell-gauntlets			Added
shell-helmet			Added
shell-secured			Added
shell			Added
standard-plating			Added

Edit: diff updated after d89185d

sleepyyapril · 2025-01-23T01:30:01Z

I know for a fact there's an absolute fuckton of test fails in regards to this: ensure they all die.

…-Engines into modsuits

Erisfiregamer1 · 2025-01-23T02:37:49Z

I know for a fact there's an absolute fuckton of test fails in regards to this: ensure they all die.

Why do you think I didn't draft it? I'll have them all dead HOPEFULLY!!! by the time Tyler can review. Hopefully.

Erisfiregamer1 · 2025-01-24T18:01:15Z

Testfail is heisen and all of Death's comments are resolved, waiting for a review

Erisfiregamer1 · 2025-01-25T00:20:18Z

@DEATHB4DEFEAT Please either dismiss your review or re-review the PR so it can get merged 🙏

All tests passing,

DEATHB4DEFEAT · 2025-01-25T00:20:44Z

womp

Erisfiregamer1 · 2025-01-25T00:21:57Z

womp

sleepyyapril

Solve UI comments

Erisfiregamer1 · 2025-01-25T02:01:25Z

Solve UI comments

PLEASE DONT DO THIS TO ME

Erisfiregamer1 · 2025-01-25T14:43:22Z

All UI comments resolved, ready for merge

…-Engines into modsuits

Erisfiregamer1 · 2025-01-25T16:21:17Z

The test fails are heisentests

Content.Client/_Goobstation/Clothing/ToggleableClothingRadialMenu.xaml.cs

VMSolidus · 2025-01-25T16:27:02Z

Content.Server/Atmos/EntitySystems/BarotraumaSystem.cs

@@ -51,6 +57,27 @@ private void OnPressureImmuneRemove(EntityUid uid, PressureImmunityComponent pre
            }
        }

+        // Goobstation - Modsuits - Update component state on toggle
+        private void OnPressureProtectionChanged(EntityUid uid, PressureProtectionComponent pressureProtection, EntityEventArgs args)


This reminds me that I would LOVE to eventually have a system that makes it so that taking enough damage while wearing space gear makes it lose its pressure protection(Or "Degrade" its pressure protection). That is until the suit is repaired, which is a process that requires you first take the suit off, and either sew back up the kevlar seals if it's a vacsuit, or otherwise weld the holes back shut. That was actually the intended way to differentiate Vacsuits > Hardsuits > Tacsuits > Modsuits

Vacsuits: Cheap as fuck, extremely common. ANY amount of physical damage ruins the protection. You are NOT fighting in these.

Hardsuits: Has extremely significant "Pressure sealing" against anything other than Piercing damage. You can get hit by a rock in space, and the suit will probably still work. Gunfire however will fuck it up. Don't wear one to a gunfight.

Tacsuits: Trades the "Blunt Object Sealing" for "Gunfire Sealing". Can take a burst of machine gun fire and still be able to keep the void of space from boiling off your eyeballs. Don't wear one to a meteor shower.

Modsuits: The tradeoff between Hardsuit & Tacsuit's style of protection is essentially an "Operator's Choice" slider depending on how its configured. I imagine it almost like the comparison between Clan Omnimechs and Inner Sphere Battlemechs. The former's a mech where you basically throw your whole bank account into a furnace to gain the ability to hotswap mech configurations within an hour instead of weeks/months. The latter being cheap industrial quantity manufactured workhorses that are made to do just one thing and be good at only that one thing.

Don't consider this comment to be a requirement by the way, just musings.

That would be awesome and I agree. Maybe in PR 2 (general touch-ups)?

Please don't, I have an idea for it already

Content.Server/Body/Systems/LungSystem.cs

Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

Update required on comp, doing that now Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

…enu.xaml.cs Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

Resources/Prototypes/_Goobstation/Research/experimental.yml

OK Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

Erisfiregamer1 · 2025-01-25T16:45:31Z

What's next, Remuchi requesting changes?

stale

Erisfiregamer1 · 2025-01-25T17:16:23Z

Heisentest

What have I chosen to do here? What is the end goal?

eefdf2f

Erisfiregamer1 marked this pull request as ready for review January 23, 2025 01:22

Erisfiregamer1 requested review from sleepyyapril, VMSolidus and Remuchi as code owners January 23, 2025 01:22

github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI labels Jan 23, 2025

Merge branch 'master' into modsuits

2c2d5e5

github-actions bot added the Status: Needs Review Someone please review this label Jan 23, 2025

SimpleStation14 changed the title ~~MODsuits (Port from Goob #1242)~~ MODsuits (Port From Goob #1242) Jan 23, 2025

Erisfiregamer1 added 2 commits January 22, 2025 20:39

A

7c5e0bb

Merge branch 'modsuits' of https://github.com/Erisfiregamer1/Einstein…

e433036

…-Engines into modsuits

Erisfiregamer1 requested a review from DEATHB4DEFEAT as a code owner January 23, 2025 01:40

github-actions bot added Changes: C# Changes any cs files Changes: UI Changes any XAML files labels Jan 23, 2025

Erisfiregamer1 added 10 commits January 22, 2025 20:45

Porting

f975bad

guh

bf5642e

Hell

d4cc0bb

MORE FIXES!!!

a65dd57

fix

09bbdaa

Robbery of Goobcode

154c4e1

Fix 1

81f38c2

MORE FIX

904267e

I feel like this'll breka shit

57e026e

I am losing my grip on reality, AGAIN

5dbafaa

Cleanup (Mostly just hitting tests with lots of BRICKS)

3e260e2

github-actions bot added the Changes: Map Changes any yml file in the Maps directories label Jan 23, 2025

Erisfiregamer1 added 2 commits January 24, 2025 11:46

patc

8b6992a

Patches !!!

4984829

Merge branch 'master' into modsuits

59c3369

sleepyyapril previously requested changes Jan 25, 2025

View reviewed changes

Erisfiregamer1 added 3 commits January 25, 2025 09:43

Help.

32f68dc

Merge branch 'modsuits' of https://github.com/Erisfiregamer1/Einstein…

7ee91cc

…-Engines into modsuits

Merge branch 'master' into modsuits

53d0845

VMSolidus requested changes Jan 25, 2025

View reviewed changes

Erisfiregamer1 and others added 3 commits January 25, 2025 11:37

Update Content.Server/Body/Systems/LungSystem.cs

6da4071

Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

Update Content.Server/Body/Systems/LungSystem.cs

b9ecc76

Update required on comp, doing that now Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

Update Content.Client/_Goobstation/Clothing/ToggleableClothingRadialM…

442be7c

…enu.xaml.cs Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

VMSolidus requested changes Jan 25, 2025

View reviewed changes

Resources/Prototypes/_Goobstation/Research/experimental.yml Outdated Show resolved Hide resolved

Erisfiregamer1 and others added 2 commits January 25, 2025 11:42

GRAHHHHH

7f5d1e4

Update Resources/Prototypes/_Goobstation/Research/experimental.yml

87f84a5

OK Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Eris <erisfiregamer1@gmail.com>

WHY.

d89185d

VMSolidus approved these changes Jan 25, 2025

View reviewed changes

sleepyyapril approved these changes Jan 25, 2025

View reviewed changes

VMSolidus merged commit cb06c41 into Simple-Station:master Jan 25, 2025
12 of 13 checks passed

SimpleStation14 added a commit that referenced this pull request Jan 25, 2025

Automatic Changelog Update (#1640)

805aba7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MODsuits (Port From Goob #1242) #1640

MODsuits (Port From Goob #1242) #1640

Erisfiregamer1 commented Jan 23, 2025 •

edited by DEATHB4DEFEAT

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

sleepyyapril commented Jan 23, 2025

Erisfiregamer1 commented Jan 23, 2025

Erisfiregamer1 commented Jan 24, 2025

Erisfiregamer1 commented Jan 25, 2025 •

edited

Loading

DEATHB4DEFEAT commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025

sleepyyapril left a comment

Erisfiregamer1 commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025 •

edited

Loading

VMSolidus Jan 25, 2025

VMSolidus Jan 25, 2025

Erisfiregamer1 Jan 25, 2025

sleepyyapril Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025

MODsuits (Port From Goob #1242) #1640

MODsuits (Port From Goob #1242) #1640

Conversation

Erisfiregamer1 commented Jan 23, 2025 • edited by DEATHB4DEFEAT Loading

Description

TODO

Media

Modsuit crafting

Modsuit sealing

Changelog

github-actions bot commented Jan 23, 2025 • edited Loading

sleepyyapril commented Jan 23, 2025

Erisfiregamer1 commented Jan 23, 2025

Erisfiregamer1 commented Jan 24, 2025

Erisfiregamer1 commented Jan 25, 2025 • edited Loading

DEATHB4DEFEAT commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025

sleepyyapril left a comment

Choose a reason for hiding this comment

Erisfiregamer1 commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025 • edited Loading

VMSolidus Jan 25, 2025

Choose a reason for hiding this comment

VMSolidus Jan 25, 2025

Choose a reason for hiding this comment

Erisfiregamer1 Jan 25, 2025

Choose a reason for hiding this comment

sleepyyapril Jan 25, 2025

Choose a reason for hiding this comment

Erisfiregamer1 commented Jan 25, 2025

Erisfiregamer1 commented Jan 25, 2025

Erisfiregamer1 commented Jan 23, 2025 •

edited by DEATHB4DEFEAT

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

Erisfiregamer1 commented Jan 25, 2025 •

edited

Loading

Erisfiregamer1 commented Jan 25, 2025 •

edited

Loading