-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arrays in SetBlockList #102
Conversation
此次修改的时候,只保留了 blockListCompiled 和 ipBlockListCompiled ,然后把config.json,文件或者链接中的内容全部解析到一个位置 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub 的在线 diff 有些混乱, 不过看起来大体上应该是没什么问题.
直接 content = StrTrim(ProcessRemark(content)) 吗? |
已经修复 用的时候还遇到一件事,URL多了之后卡了一会,发现URL超时了。现在给URL加了个并发化 |
请求审查 |
谢谢, 已经合并. 尽管大致上没有问题了, 但有一点想法: 为 URL 引入并发的复杂性是否值得. 考虑到 URL Interval 一般都大于 300 秒, 一段时间的超时应当是可以容忍的, 特别是在首次获取完成有本地列表后, 只需要为这一动作加入异步和防止重复获取的简单锁即可. 但这不对合并构成影响. |
你不说,我都忘了给map换成线程安全的那一种了 |
使得 SetBlockFromFile SetBlockFromURL SetIPBlockFromFile SetIPBlockFromURL 支持数组