Move VTK utilities to sub-module #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowekamp
force-pushed
the
vtk_module
branch
3 times, most recently
from
fca5faf
to
b8a9d9e
Compare
The following import no longer works: from SimpleITK.utilities import sitk2vtk This needs to be changed to: from SimpleITK.utilities.vtk import sitk2vtk Removed the import of the large vtk package when importing Simpleitk.utilities. This can improve performance when vtk is not needed when using other provided utilities. This follow the pattern of other optional dependencies for the Utilities.
|
@dave3d I thought this PR was merged already. This PR move the vtk functions a bit so that the vtk module is not imported when the utilities package is imported. |
dave3d
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move sitk2vtk to vtk submodule
Removed the import of the large vtk package when importing Simpleitk.utilities. This can improve performance when vtk is not needed when using other provided utilities. This follow the pattern of other optional dependencies for the Utilities.