Tweaks CSS for insert menu for small images #7737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Merged
|
@Sesquipedalian - I'm testing & comparing this to the other solution. I don't think this one fixes the typo on line ~33 that is causing console warnings (and invalidates the css). |
|
I'll add a fix for that later today. |
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
|
@sbulen: Done. |
|
After comparing the two, I prefer the alternate approach. Looks less cluttered. |
|
As you wish. |
DiegoAndresCortes
approved these changes
Jul 26, 2023
|
Is this still making 2.1.5? I forgot if another decision was made. |
|
Yes. We've seen other examples of overflow reported on the forum. This acts as a safety net... |
In light of @DiegoAndresCortes approval and this statement, I will go ahead and merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7735
Rather than changing the min-height of the preview wrapper, this adjusts the z-index of the menu div and the overflow properties of the relevant container divs. It also adjusts the border-radius on the corners of the file size progress bar, because I was formerly relying on the overflow properties to take care of hiding those corners where they would otherwise spill outside the rounded corners of the container.