Does not work with SMF 2.1.2 and MediaWiki 1.38.2 #20
Milestone
Comments
|
Part of the problem was fixed by changing constructor of public function __construct( $params = [] ) {
$loadBalancer = \MediaWiki\MediaWikiServices::getInstance()->getDBLoadBalancer();
parent::__construct( $loadBalancer, $params );
}Now there are no more fatal errors but auth does not work. |
|
The set of errors I've got after the fix for |
|
I haven't tested at all with 1.38. The later error looks like it isn't including the SMF Settings.php file properly or a global issue. Is your path to the SMF settings.php correct? |
|
I think I've got it. |
|
Ok, just a typo in the documentation. I will get it updated when I can. I will have to branch the repo because I suspect the changes for 1.38 are not compatible with the current LTS, which is what this is targeting. |
|
Ok. I've got it. After the fix for Any clue on what is the cause? |
|
It seems that The last content for public function isLoggedIn() {
return $this->isRegistered();
}So |
|
Next missing method is /**
* Get the list of implicit group memberships this user has.
* This includes all explicit groups, plus 'user' if logged in,
* '*' for all accounts, and autopromoted groups
*
* @deprecated since 1.35 Use UserGroupManager::getUserEffectiveGroups instead
*
* @param bool $recache Whether to avoid the cache
* @return string[] internal group names
*/
public function getEffectiveGroups( $recache = false ) {
return MediaWikiServices::getInstance()
->getUserGroupManager()
->getUserEffectiveGroups( $this, $this->queryFlagsUsed, $recache );
} |
|
Missing method /**
* Set the given option for a user.
*
* You need to call saveSettings() to actually write to the database.
*
* @param string $oname The option to set
* @param mixed $val New value to set
* @deprecated since 1.35 Use UserOptionsManager::setOption instead
*/
public function setOption( $oname, $val ) {
MediaWikiServices::getInstance()
->getUserOptionsManager()
->setOption( $this, $oname, $val );
} |
|
I'm not sure if that's directly useful but there is modified versions of extension files. With them things run fine on MediaWiki 1.38.2. It's likely that you may want to re-format changes to provide better match for your code style. ForumSsoProvider_patch_for_1.38.zip I assume these changes are needed for any from 1.35 and newer |
|
The recent PR #21 should resolve these up. It works on 1.38, but I'm targeting it at 1.39 as I've only been targeting LTS releases. |
|
Might then be a good idea to mention that in the readme
…On Wed, Aug 10, 2022 at 1:22 PM Jeremy D ***@***.***> wrote:
The recent PR #21 <#21>
should resolve these up. It works on 1.38, but I'm targeting it at 1.39 as
I've only been targeting LTS releases.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN7VBBT5GZGDZAXE33DVYQFRFANCNFSM55F5YBYQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I put 1.38+ in the readme. I will bump it to say 1.39 when they release it. Assuming that 1.39 will have no significant changes, it should work. |
|
mention that you only really test on lts versions
…On Wed, Aug 10, 2022 at 7:56 PM Jeremy D ***@***.***> wrote:
I put 1.38+ in the readme. I will bump it to say 1.39 when they release
it. Assuming that 1.39 will have no significant changes, it should work.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN44DAP6JQ6L24AU5TDVYRTVVANCNFSM55F5YBYQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
WIll do. I don't mind master following the non LTS, but I think it makes sense to branch out for any LTS. If somebody has time to follow the non LTS versions and update the extension, then great. |
|
@jdarwood007 I've tried #21 with MediaWiki 1.39.1 (LTS) and SMF 2.1.3 and it gives me the following errors: Any ideas? |
|
Seems like they did a few more changes. They both sound like it should be simple to fix. Will try when I get time. |
|
@berianwilliams Replace: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On SMF 2.1.2 and MediaWiki 1.38.2 I'm getting this:
Steps to reproduce
Environment (complete as necessary)
The text was updated successfully, but these errors were encountered: