Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/Export encryption and progress notification #317

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Spitfireap
Copy link
Contributor

NOTE : This is a work in progress. It is working, but some cleanup is needed, and I need to test it with a great amount of data.

Since exporting messages saves them into a json. It would be easy to grep a bunch of phone number, messages and mms, so I thought of adding this. It is completely based on FairEmail implementation.

  • It won't affect older backup, and new backup can be created w/o a password.

To encrypt the backup, simply input a password on the export dialog. Extension will be changed to .json to .sec by default.
To decrypt, put the same password you provided at first.

@Spitfireap
Copy link
Contributor Author

@tibbi okay, strings are done.
I'm starting java and Kotlin, so I have trouble understanding how onProgress.invoke() in MessagesImporter().importMessages() is processed (is it actually?). I was wondering if I could use it to set an import progress bar or progress count...

@tibbi
Copy link
Contributor

tibbi commented Mar 3, 2022

it was @KryptKode doing it, onProgress isnt doing anything now. Guess it was some preparation for showing a progress bar, but we can remove it until it gets actually used.

@Spitfireap Spitfireap marked this pull request as ready for review March 9, 2022 14:50
@Spitfireap
Copy link
Contributor Author

Okay, I think it's ready.
I did some test, and it worked well. I could test with a backup size up to 150MB.
I didn't remove the OnProgress Unit, it could be really useful since backups tends to take some time to restore, but I have no clue on how to link it to a Dialog function...

@Spitfireap Spitfireap changed the title WIP: Option to encrypt message exports Option to encrypt message exports Mar 9, 2022
@Spitfireap
Copy link
Contributor Author

Okay so I documented myself a bit on Unit in Kotlin, and here is a progress notification system for importing/exporting :)

@Spitfireap Spitfireap changed the title Option to encrypt message exports Import/Export encryption and progress notification Mar 9, 2022
@Spitfireap
Copy link
Contributor Author

Heu @tibbi, is it possible to merge, or you don't want the feature? I can update it if you want

@tibbi
Copy link
Contributor

tibbi commented Jul 15, 2022

I dont know, havent tested it properly yet, will take a look at it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants