Skip to content

Commit

Permalink
libgit2: add python as test dependency (spack#40863)
Browse files Browse the repository at this point in the history
Libgit2 requires python as build dependency. I was getting an error because it was falling back to system Python which is compiled with Intel compilers and thus, `libgit2` was failing because it couldn't find `libimf.so` (which doesn't make sense).

Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
  • Loading branch information
mofeing and haampie authored Nov 8, 2023
1 parent 53c266b commit 3405fe6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions var/spack/repos/builtin/packages/libgit2/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ class Libgit2(CMakePackage):
depends_on("cmake@2.8:", type="build", when="@:0.28")
depends_on("cmake@3.5:", type="build", when="@0.99:")
depends_on("pkgconfig", type="build")
depends_on("python", type="test")

# Runtime Dependencies
depends_on("libssh2", when="+ssh")
Expand Down Expand Up @@ -123,5 +124,6 @@ def cmake_args(self):

# Control tests
args.append(self.define("BUILD_CLAR", self.run_tests))
args.append(self.define("BUILD_TESTS", self.run_tests))

return args

0 comments on commit 3405fe6

Please sign in to comment.