Skip to content

Commit

Permalink
Specify store mail_from_address in spec
Browse files Browse the repository at this point in the history
The store factory was updated in solidusio/solidus#3849

Although I see the "with_args" helper is being used elsewhere to
allow for asserting against dynamic payloads, the only reason
this value is changing on us is because of the unspoken dependency
on the attributes in a solidus factory. If Solidus is going to
embrace this kind of churn then we'd probably be best to set
all relevant attributes explicitly.
  • Loading branch information
Sinetheta committed Dec 14, 2020
1 parent 9fc466e commit 2cca59f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion spec/integration/queries/current_store_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

RSpec.describe_query :currentStore, query: :current_store, freeze_date: true do
let!(:store) { create(:store, :with_defaults) }
let!(:store) { create(:store, :with_defaults, mail_from_address: 'solidus_graphql_api@example.org') }

before { Spree::Config.available_currencies = ::Money::Currency.first(2) }

Expand Down
2 changes: 1 addition & 1 deletion spec/support/graphql/responses/current_store.json.erb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"default": true,
"defaultCurrency": "USD",
"mailFromAddress": "spree@example.org",
"mailFromAddress": "solidus_graphql_api@example.org",
"metaDescription": "store description",
"metaKeywords": "store, metaKeywords",
"name": "Solidus Test Store",
Expand Down

0 comments on commit 2cca59f

Please sign in to comment.