-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues 254, 279 and 292 🚸 add some thousands of porn domains #296
Conversation
@thomasmerz There are two mistaken lines on your list:
I can also see that you've removed many lines. I did not review them yet, but I hope you did not remove sub-domains of blocked domains, as this is a hosts list subdomains should be added/blocked individually. |
I've find that yandex.ru and similar level domains are blocked too, which should not be the case I think? |
@thomasmerz
|
Verified against some upstream paid porn blacklists. Most of the domains in this specific commit have been grabbed from this pr Sinfonietta#296
These change came from @jobbb2 - I tried to help him, but as I asked in #279 (comment) I personally think that it's not good to have sooooo many changes because nobody can check them anymore 😢 So I asked @Sinfonietta if we "should close these PRs and start from scratch and in smaller batches"… |
@thomasmerz I've checked each individual domain in this pr against a paid upstream porn DNS block service. and added each domain that's confirmed as porn to this commit Raviu56@f138c45 |
Ok, great! I will close this PR. Thanks for your checking! |
This PR obsoletes #294 and #295.
This PR closes #254 and #279 and #292.