This repository was archived by the owner on Jun 9, 2019. It is now read-only.
Add "compare_base.py" to help package maintenance #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
A few months ago I've written a small Python script which checks for updates for every base package that needs to be recompiled with SELinux support ("the -selinux packages"). Now that I've cleaned up the code and tested it today, this script is in a kind of alpha state : it is working quite well on my system but it needs to be tested and reviewed, just to be sure there is no obvious bug lying around before pushing to
master
...I've written this script with the focus of keeping things simple and intuitive. So
compare_base.py
doesn't take any command line parameter, reads package information frombase_pkglist.txt
(new file written in a config-like language, with a documentation header) and downloads withyaourt -G
the base packages into abase-noselinux/
directory.From a maintainer point of view, the major difference is that
base_pkglist.txt
needs to be updated after each update, because the PKGBUILDs of the -selinux packages don't include thepkgrel
field of the base package. This would be quite simple, but as it is easy to forget I've added a check in the script which verify that thepkgver
value is the same betweenPKGBUILD
andbase_pkglist.txt
. An other way of keeping track of the "basepkgrel
value" could be adding a variable inPKGBUILD
, but I don't like this idea much.Here are some ideas that weren't implemented but might be added in a future version of this script, if an elegant implementation is found:
${pkgname}
with${pkgname/-selinux}
, change the description text... so that the diff with the PKGBUILD of the -selinux packages is smaller.Finally, here are minor choices I've made:
Nicolas