Port to Python 3 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciate this, but I don't have the time to continue work on this. I mean, I've done nothing to it for months. More than a year now. And I don't think I'll ever continue on it because WHOIS servers are a bloody nightmare. But thank you for the effort! |
|
And I do really appreciate your work! I agree that WHOIS is far from ideal. Probably there is no incentive for registrars to stick to a standard output format. |
use with statement when working with files as this handles closing them correctly
refactor: use with statement
Make the regex in parse.reprocess_regex work with Python 3.7+
Remove unnecessary calls to encode('utf-8')
Remove the Python 2 version of parse.is_string
Refer to python3 in the #! of whois-oracle.py Replace references to pwhois with whois-oracle in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes needed to make the code run on Python 3.
One is using
configparseinstead ofConfigParseand the other is usingitems()instead ofiteritems()(it should work on Python 2 too.)Unfortunately the new code won't run on Python 2.
Maybe it can become cross platform by following the advice at http://python-future.org/compatible_idioms.html#configparser