Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on hit #837

Closed
mihaibalau opened this issue Jul 5, 2024 · 8 comments
Closed

Error on hit #837

mihaibalau opened this issue Jul 5, 2024 · 8 comments
Labels
Bug An issue that is not supposed to happen

Comments

@mihaibalau
Copy link

Server Implementation

Spigot

Server Version

1.21

Describe the bug

Here is the error: https://mclo.gs/R0BSR8T

Reproduction Steps

  1. Hit a player on Paper, 1.21

Expected behaviour

This error appear each time when a player is hit by another.

Screenshots / Videos

No response

latest log file (if applicable)

No response

CombatLogX Version

[10:22:40 INFO]: - BlueSlimeCore v2.9.6.431
[10:22:40 INFO]: CombatLogX by SirBlobman
[10:22:40 INFO]: Local Version: 11.5.0.0.1242
[10:22:40 INFO]: Remote Version: 11.5.0.0.1242
[10:22:40 INFO]: Enabled Expansions (10):
[10:22:40 INFO]: - Action Bar v17.3
[10:22:40 INFO]: - Cheat Prevention v17.7
[10:22:40 INFO]: - EssentialsX Compatibility v17.2
[10:22:40 INFO]: - LuckPerms Compatibility v17.1
[10:22:40 INFO]: - PlaceholderAPI Compatibility v17.2
[10:22:40 INFO]: - WorldGuard Compatibility v17.3
[10:22:40 INFO]: - Damage Effects v17.2
[10:22:40 INFO]: - Damage Tagger v17.1
[10:22:40 INFO]: - Glowing v17.0
[10:22:40 INFO]: - Scoreboard v17.1

Anything else?

No response

@mihaibalau mihaibalau added the Bug An issue that is not supposed to happen label Jul 5, 2024
@PabloGirol
Copy link

PabloGirol commented Jul 6, 2024

I have the same issue, seems to be an issue caused by spigot they, seem to have changed the type of the original InventoryView Class to an Interface...

@SirBlobman
Copy link
Owner

Set the option close-on-retag to false in inventories.yml for the Cheat Prevention expansion. I'm not sure why Spigot decided to change that class file and break plugins 😐

@Olivoz
Copy link
Contributor

Olivoz commented Jul 6, 2024

I believe Spigot uses ASM to patch plugins to maintain backwards compatibility. Now the problem is that CombatLogX uses it's own expansion class loader which doesn't do that. Might be worth looking in to if we can hook that system.

@mihaibalau
Copy link
Author

Set the option close-on-retag to false in inventories.yml for the Cheat Prevention expansion. I'm not sure why Spigot decided to change that class file and break plugins 😐

Thank you so much for your answer! If I change only close-on-retag the error still appear but I disabled all things from there and is fine now.

@SamsimIsMe
Copy link

disabling close-on-retag doesnt work for me

@Olivoz
Copy link
Contributor

Olivoz commented Aug 12, 2024

disabling close-on-retag doesnt work for me

Try disabling close as well

@SamsimIsMe
Copy link

still doesnt work olivoz

@Olivoz
Copy link
Contributor

Olivoz commented Aug 12, 2024

still doesnt work olivoz

I'm unable to recreate the issue with the settings disabled. Please open your own GitHub issue and provide the required information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue that is not supposed to happen
Projects
None yet
Development

No branches or pull requests

5 participants