CheckBox Editor does not work as expected in Safari #1458
Comments
msssk
added a commit
to msssk/dgrid
that referenced
this issue
Apr 25, 2020
In OS X form controls are not considered focusable elements. Some browsers (Safari, Firefox) adopt this decision: whatwg/html#4356 https://bugzilla.mozilla.org/show_bug.cgi?id=1524863 https://bugs.webkit.org/show_bug.cgi?id=22261 The resulting implementation is broken - you can call `focus()` on a checkbox and it will be focused, but clicking on a checkbox does not focus it. Further, clicking on a focused checkbox blurs it. To overcome these challenges checkboxes and radios are wrapped in a div that can receive focus (and blur) in a consistent manner. Fixes SitePen#1458
|
Is it also possible to have this fix applied to dgrid 0.3.16? |
msssk
added a commit
that referenced
this issue
Apr 27, 2020
Editor: wrap checkbox and radio button shared editors on Mac In OS X form controls are not considered focusable elements. Some browsers (Safari, Firefox) adopt this decision: whatwg/html#4356 https://bugzilla.mozilla.org/show_bug.cgi?id=1524863 https://bugs.webkit.org/show_bug.cgi?id=22261 The resulting implementation is broken - you can call `focus()` on a checkbox and it will be focused, but clicking on a checkbox does not focus it. Further, clicking on a focused checkbox blurs it. To overcome these challenges checkboxes and radios are wrapped in a div that can receive focus (and blur) in a consistent manner. Fixes #1458
msssk
added a commit
that referenced
this issue
Apr 28, 2020
Editor: wrap checkbox and radio button shared editors on Mac In OS X form controls are not considered focusable elements. Some browsers (Safari, Firefox) adopt this decision: whatwg/html#4356 https://bugzilla.mozilla.org/show_bug.cgi?id=1524863 https://bugs.webkit.org/show_bug.cgi?id=22261 The resulting implementation is broken - you can call `focus()` on a checkbox and it will be focused, but clicking on a checkbox does not focus it. Further, clicking on a focused checkbox blurs it. To overcome these challenges checkboxes and radios are wrapped in a div that can receive focus (and blur) in a consistent manner. Fixes #1458
msssk
added a commit
that referenced
this issue
Apr 28, 2020
In OS X form controls are not considered focusable elements. Some browsers (Safari, Firefox) adopt this decision: whatwg/html#4356 https://bugzilla.mozilla.org/show_bug.cgi?id=1524863 https://bugs.webkit.org/show_bug.cgi?id=22261 The resulting implementation is broken - you can call `focus()` on a checkbox and it will be focused, but clicking on a checkbox does not focus it. Further, clicking on a focused checkbox blurs it. To overcome these challenges checkboxes and radios are wrapped in a div that can receive focus (and blur) in a consistent manner. Fixes #1458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using Safari 13, the checkbox is not clickable when editOn = click. To reproduce this issue, navigate to the editor tests:
https://dgrid.io/js/dgrid/test/Editor.html
Select:
Press the "Recreate Grid" button.
You will notice that when selecting the text (true/false) on the rendered cell, the checkbox will show up. However, if you try to toggle the checkbox, the grid is blurred and the value never changes.
The text was updated successfully, but these errors were encountered: