Refactor sort to additionally support passing a sort options array #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to run criteria passed via queryOptions to OnDemandList through the sort function of the list/grid, which in the case of Grid, also updates the sort arrow in the UI. It might also enable us to consider supporting nested sort via a plugin in the future. Haven't thought too hard about that yet.
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2011
Refactor sort to additionally support passing a sort options array
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to run criteria passed via queryOptions to OnDemandList
through the sort function of the list/grid, which in the case of Grid,
also updates the sort arrow in the UI.
It might also enable us to consider supporting nested sort via a
plugin in the future. Haven't thought too hard about that yet.
I've tested this across browsers, across test pages, and haven't seen any regressions, but I'd welcome any feedback or testing by others.