ColumnSet lacks ARIA roles, breaks JAWS #616
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ColumnSet mixin isn't providing ARIA roles for the DOM it's creating, and this is apparently causing JAWS to skip reading the content contained therein.
I'm not terribly familiar with all the nuances of ARIA roles, but from my reading of the spec, I would've thought that all it would take is adding
[role=presentation]
to the.dgrid-row-table
node created increateRowCells()
. However, the testing team I'm working with reports that this isn't sufficient, and that JAWS isn't reading the content until we add[role=presentation]
to some other nodes created by this mixin. After that's done, JAWS is apparently perfectly happy.I have no way of testing this here on my machine at this point, so I can't verify the accuracy of the findings, but I've prepared a pull request with the changes anyway, if only to kick off a discussion.
(apologies for the proxy submission; this is coming from a project for a client who's not particularly GitHub-savvy)