Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Hero to support editor editing and Storybook fixes #404

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

PerficientDave
Copy link
Contributor

Updating the field types to use Sitecore fields to be compatible with Experience Editor and Pages

Description / Motivation

The component wasn't able to be updated inline within Experience Editor or Pages

How Has This Been Tested?

Locally in Sitecore and Storybook

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@robearlam robearlam merged commit 0106d81 into Sitecore:main Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants