[create-sitecore-jss] Better wording around multiple apps installed (#…

…1888)
Sitecore · Aug 14, 2024 · 0777253 · 0777253
1 parent a422356
commit 0777253
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/packages/create-sitecore-jss/src/common/processes/next.test.ts b/packages/create-sitecore-jss/src/common/processes/next.test.ts
@@ -26,8 +26,22 @@ describe('next', () => {
       expect(
         calls.some(
           (call) =>
-            call.args[0] ===
-            `JSS application(s) ${chalk.green('my-cool-app, second-app')} are ready!`
+            call.args[0] === `JSS applications ${chalk.green('my-cool-app, second-app')} are ready!`
+        )
+      ).to.equal(true);
+    });
+
+    it('displays single app name with single item wording in output', async () => {
+      const appNames = ['my-cool-app'];
+      await nextSteps(appNames, []);
+
+      const calls = log.getCalls();
+      calls.forEach((call) => {
+        console.log(call.args[0]);
+      });
+      expect(
+        calls.some(
+          (call) => call.args[0] === `JSS application ${chalk.green('my-cool-app')} is ready!`
         )
       ).to.equal(true);
     });

diff --git a/packages/create-sitecore-jss/src/common/processes/next.ts b/packages/create-sitecore-jss/src/common/processes/next.ts
@@ -6,6 +6,10 @@ import chalk from 'chalk';
  * @param {string[]} nextStepsArr next steps to be performed after app is created
  */
 export const nextSteps = async (appNames: string[], nextStepsArr: string[]) => {
+  const successMessage =
+    appNames.length > 1
+      ? `JSS applications ${chalk.green(appNames.join(', '))} are ready!`
+      : `JSS application ${chalk.green(appNames[0])} is ready!`;
   console.log(chalk.red('                 -/oyhdmNNNNmdhyo/-                '));
   console.log(chalk.red('             :sdMMMMMMMMMMMMMMMMMMMMds:            '));
   console.log(chalk.red('          :yNMMMMMMMMMMMMMMMMMMMMMMMMMMNy:         '));
@@ -37,11 +41,7 @@ export const nextSteps = async (appNames: string[], nextStepsArr: string[]) => {
   console.log(chalk.white('                 / // /\\ \\_\\ \\  '));
   console.log(chalk.white('                 \\___/___/___/'));
   console.log();
-  console.log(
-    `JSS application(s) ${chalk.green(appNames.join(', '))} ${
-      appNames.length > 1 ? 'are' : 'is'
-    } ready!`
-  );
+  console.log(successMessage);
   console.log();
   console.log(chalk.yellow('Next steps:'));
   nextStepsArr.forEach((step) => {