Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netlify] Allow public URL detection #1585

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Aug 10, 2023

Description / Motivation

Part of the effort to improve Netlify support. Allows for public URL detection so that specifying PUBLIC_URL env variable is no longer needed.
Uses Netlify's DEPLOY_URL variable to be in line with our implementation for Vercel support.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team August 10, 2023 17:08
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question

packages/sitecore-jss-nextjs/src/utils/utils.ts Outdated Show resolved Hide resolved
@ambrauer ambrauer merged commit 771bf8d into dev Aug 15, 2023
1 check passed
@ambrauer ambrauer deleted the feature/jss-219-netlify-public-url-detect branch August 15, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants