Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nextjs-sxa] Don't let Image component wrap <img> with <a> tag when TargetUrl is not configured #1594

Merged
merged 3 commits into from
Aug 23, 2023
Merged

[nextjs-sxa] Don't let Image component wrap <img> with <a> tag when TargetUrl is not configured #1594

merged 3 commits into from
Aug 23, 2023

Conversation

Elyseum
Copy link
Contributor

@Elyseum Elyseum commented Aug 18, 2023 •
edited
Loading

Description / Motivation

See #1593.
Don't wrap IMG with A when TargetUrl has no href value.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

AFAIK there are no unit tests for nextjs-sxa components.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Elyseum Elyseum changed the title Don't wrap image in link when not configured [nextjs-sxa] Don't let Image component wrap <img> with <a> tag when TargetUrl is not configured Aug 18, 2023
@Elyseum Elyseum marked this pull request as ready for review August 18, 2023 14:06
@illiakovalenko illiakovalenko merged commit 0e7a5c6 into Sitecore:dev Aug 23, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi sc-ruslanmatkovskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elyseum @sc-ruslanmatkovskyi @illiakovalenko