[Next.js][RAV][node-headless-ssr] Add Sitecore prefix to SITE_NAME environment variable and config #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
changed the title
illiakovalenko
approved these changes
Nov 22, 2023
packages/create-sitecore-jss/src/templates/angular/scripts/generate-config.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/scripts/generate-config.js
Outdated
Show resolved
Hide resolved
ambrauer
added a commit
that referenced
this pull request
Nov 22, 2023
…vironment variable and config (#1672) * Add "sitecore" prefix to SITE_NAME environment variable and config * updated CHANGELOG and one missed file * remove unnecessary config.jssAppName from Angular and Vue to avoid confusion # Conflicts: # packages/create-sitecore-jss/src/templates/angular/.env # packages/create-sitecore-jss/src/templates/nextjs/.env # packages/create-sitecore-jss/src/templates/react/.env # packages/create-sitecore-jss/src/templates/vue/.env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This is a follow-up to #1640 and #1647 which adds a Sitecore prefix to the new
SITE_NAMEenvironment variable and corresponding JSS config (so,SITECORE_SITE_NAMEandconfig.sitecoreSiteName). This allows us to avoid environment variable name conflicts on deployment platforms (e.g.SITE_NAMEis a reserved env variable on Netlify).Also, re-introduces
SITECORE_JSS_APP_NAMEto the node-headless-ssr templates as this is still necessary (used differently than site name) in these apps.Testing Details
Types of changes