[XM Cloud][Next.js] Editing Configuration Endpoint #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s; modify component builder codegen to export components
addy-pathania
requested changes
Feb 2, 2024
packages/sitecore-jss-nextjs/src/editing/editing-config-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-config-middleware.test.ts
Show resolved
Hide resolved
ambrauer
reviewed
Feb 2, 2024
packages/create-sitecore-jss/src/templates/nextjs/scripts/generate-metadata.ts
Show resolved
Hide resolved
| import { getJssEditingSecret } from '../utils/utils'; | ||
| import { debug } from '@sitecore-jss/sitecore-jss'; | ||
|
|
||
| interface Metadata { |
There was a problem hiding this comment.
This interface should be exported / shared with the metadata generation
art-alexeyenko
previously requested changes
Feb 2, 2024
packages/create-sitecore-jss/src/templates/nextjs/scripts/generate-metadata.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
Feb 5, 2024
Comment on lines
14
to
16
| const metadata: Metadata = { packages: {} }; | ||
| metadata.packages = getPackagesMetadata(); | ||
| writeMetadata(metadata); |
There was a problem hiding this comment.
I would switch our SDK function to be a getMetadata() function which returns Metadata (shouldn't have any knowledge of "packages" here in the app layer). This way, if we add anything to metadata in the future, there is nothing in the app layer to update.
Suggested change
| const metadata: Metadata = { packages: {} }; | |
| metadata.packages = getPackagesMetadata(); | |
| writeMetadata(metadata); | |
| const metadata = getMetadata(); | |
| writeMetadata(metadata); |
yavorsk
changed the title
yavorsk
dismissed
art-alexeyenko’s stale review
The commented functionality has been tested and works ok :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR introduces a protected endpoint in the xmcloud addon -
/api/editing/config?secret=[jss-editing-secret]. The endpoint provides configuration information (the sitecore packages used by the app and all registered components) to be used to determine feature compatibility on pages side.Includes:
Testing Details
Types of changes