Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Use correct placeholder ID format for dynamic placeholders metadata #1828

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jun 19, 2024

Description / Motivation

Short follow up to Placeholder Metadata work. We need to ensure rendering uid is being used in editing markup for dynamic placeholders.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team June 19, 2024 17:56
@art-alexeyenko art-alexeyenko changed the title [sitecore-jss-nextjs] Use correct placeholder ID format for dynamic placeholders [sitecore-jss-nextjs] Use correct placeholder ID format for dynamic placeholders metadata Jun 19, 2024
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add/update unit tests.
Update changelog.

Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@art-alexeyenko art-alexeyenko merged commit ca3dac9 into dev Jun 20, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the bug/jss-3460-placeholder-id-format branch June 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants