Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs-xmcloud][sitecore-jss] Update render process in normal mode for component level personalization #1844

Merged
merged 17 commits into from
Jul 22, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Jul 19, 2024

Description / Motivation

This PR updates the render process in normal mode for component level personalization.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk changed the title Feature/jss 3339 [templates/nextjs-xmcloud][sitecore-jss] Update render process in normal mode for component level personalization Jul 19, 2024
@yavorsk yavorsk requested a review from a team July 19, 2024 13:24
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, still some more parts to improve. Please ensure you add an upgrade guide entry for this.

docs/upgrades/unreleased.md Outdated Show resolved Hide resolved
docs/upgrades/unreleased.md Outdated Show resolved Hide resolved
@yavorsk yavorsk requested a review from art-alexeyenko July 22, 2024 13:02
CHANGELOG.md Outdated
@@ -25,6 +25,7 @@ Our versioning strategy is as follows:
* `[sitecore-jss]` _GraphQLRequestClient_ now can accept custom 'headers' in the constructor or via _createClientFactory_ ([#1806](https://github.com/Sitecore/jss/pull/1806))
* `[templates/nextjs]` Removed cors header for API endpoints from _lib/next-config/plugins/cors-header_ plugin since cors is handled by API handlers / middlewares ([#1806](https://github.com/Sitecore/jss/pull/1806))
* `[sitecore-jss-nextjs]` Updates to Next.js editing integration to further support secure hosting scenarios (on XM Cloud & Vercel) ([#1832](https://github.com/Sitecore/jss/pull/1832))
* `[templates/nextjs-xmcloud]` `[sitecore-jss]` Updates the render process in normal mode for component level personalization. ([#1844](https://github.com/Sitecore/jss/pull/1844))
Copy link
Contributor

@art-alexeyenko art-alexeyenko Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing: please resolve changelog merge conflicts and reformat this entry as "AB testing support".
We'll have middleware and preview mode added in addition to the current change, best to have them listed under one roof

Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to do and we're good

@yavorsk yavorsk merged commit be2b1de into dev Jul 22, 2024
1 check passed
@yavorsk yavorsk deleted the feature/jss-3339 branch July 22, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants