-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[templates/nextjs-xmcloud][sitecore-jss] Update render process in normal mode for component level personalization #1844
Conversation
…edRewrite function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, still some more parts to improve. Please ensure you add an upgrade guide entry for this.
packages/sitecore-jss/src/personalize/layout-personalizer.test.ts
Outdated
Show resolved
Hide resolved
This reverts commit c18c529.
CHANGELOG.md
Outdated
@@ -25,6 +25,7 @@ Our versioning strategy is as follows: | |||
* `[sitecore-jss]` _GraphQLRequestClient_ now can accept custom 'headers' in the constructor or via _createClientFactory_ ([#1806](https://github.com/Sitecore/jss/pull/1806)) | |||
* `[templates/nextjs]` Removed cors header for API endpoints from _lib/next-config/plugins/cors-header_ plugin since cors is handled by API handlers / middlewares ([#1806](https://github.com/Sitecore/jss/pull/1806)) | |||
* `[sitecore-jss-nextjs]` Updates to Next.js editing integration to further support secure hosting scenarios (on XM Cloud & Vercel) ([#1832](https://github.com/Sitecore/jss/pull/1832)) | |||
* `[templates/nextjs-xmcloud]` `[sitecore-jss]` Updates the render process in normal mode for component level personalization. ([#1844](https://github.com/Sitecore/jss/pull/1844)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing: please resolve changelog merge conflicts and reformat this entry as "AB testing support".
We'll have middleware and preview mode added in addition to the current change, best to have them listed under one roof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing to do and we're good
Description / Motivation
This PR updates the render process in normal mode for component level personalization.
Testing Details
Types of changes