Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates/nextjs-sxa] Fix SXA Image sizing in Metadata mode #1861

Closed
wants to merge 2 commits into from
Closed

[templates/nextjs-sxa] Fix SXA Image sizing in Metadata mode #1861

wants to merge 2 commits into from

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jul 29, 2024 •
edited
Loading

Description / Motivation

next/image cannot handle width/height prop values of '100%'. We gotta use 'sizes' prop instead. https://nextjs.org/docs/pages/api-reference/components/image#responsive-images

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko
Copy link
Contributor Author

art-alexeyenko commented Jul 29, 2024 •
edited
Loading

Duplicate of #1860

@art-alexeyenko art-alexeyenko marked this as a duplicate of #1860 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi Awaiting requested review from sc-ruslanmatkovskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@art-alexeyenko