Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-angular] Angular placeholder support for SXA components #1870

Merged
merged 4 commits into from
Aug 1, 2024
Merged

[sitecore-jss-angular] Angular placeholder support for SXA components #1870

merged 4 commits into from
Aug 1, 2024

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Jul 31, 2024 •
edited
Loading

Description / Motivation

Angular placeholder support of SXA component features including:

  • dynamic placeholders
  • rendering variants (via design pattern using Angular templates)
  • convenience params (currently just 'styles' which matches our React SDK)

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) Partially tested against XMC instance with "Basic" site template

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team July 31, 2024 21:37
@ambrauer ambrauer changed the title [sitecore-jss-angular] SXA support for Angular placeholder [sitecore-jss-angular] Angular placeholder support for SXA components Jul 31, 2024
illiakovalenko
illiakovalenko approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍
Pretty clean approach
See one question below regarding sitecoreContext and check the build status, for now it's failed

packages/sitecore-jss-angular/src/components/placeholder.component.ts Outdated Show resolved Hide resolved
@ambrauer ambrauer merged commit 1d9db8b into dev Aug 1, 2024
1 check passed
@ambrauer ambrauer deleted the feature/JSS-3666 branch August 1, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambrauer @illiakovalenko