-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[angular-xmcloud] Introduce SXA layout component for angular #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r adding links to head
yavorsk
changed the title
[angular-xmcloud] Introduce sxa layout component for angular
[angular-xmcloud] Introduce SXA layout component for angular
Aug 2, 2024
ambrauer
suggested changes
Aug 6, 2024
packages/create-sitecore-jss/src/templates/angular/src/app/lib/jss-state-factory/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/src/app/lib/jss-state-factory/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/src/app/lib/jss-state-factory/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/src/app/jss-context.service.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular-xmcloud/src/app/jss-link.service.ts
Outdated
Show resolved
Hide resolved
ambrauer
suggested changes
Aug 7, 2024
packages/create-sitecore-jss/src/templates/angular/src/app/JssState.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/src/app/jss-context.service.ts
Outdated
Show resolved
Hide resolved
...eate-sitecore-jss/src/templates/angular-xmcloud/src/app/routing/layout/layout.component.html
Show resolved
Hide resolved
...eate-sitecore-jss/src/templates/angular-xmcloud/src/app/routing/layout/layout.component.html
Outdated
Show resolved
Hide resolved
...eate-sitecore-jss/src/templates/angular-xmcloud/src/app/routing/layout/layout.component.html
Show resolved
Hide resolved
...create-sitecore-jss/src/templates/angular-xmcloud/src/app/routing/layout/layout.component.ts
Show resolved
Hide resolved
...create-sitecore-jss/src/templates/angular-xmcloud/src/app/routing/layout/layout.component.ts
Outdated
Show resolved
Hide resolved
...create-sitecore-jss/src/templates/angular-xmcloud/src/app/routing/layout/layout.component.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
…to feature/jss-3773
ambrauer
reviewed
Aug 7, 2024
...create-sitecore-jss/src/templates/angular-xmcloud/src/app/routing/layout/layout.component.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just one last Q
…/app/routing/layout/layout.component.ts Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Testing Details
Types of changes