Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular-xmcloud] Introduce SXA layout component for angular #1873

Merged
merged 15 commits into from
Aug 7, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Aug 2, 2024

Description / Motivation

  • SXA Layout for angular.
  • new link service for adding links to head.
  • plugin functionality for JssState

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk changed the title [angular-xmcloud] Introduce sxa layout component for angular [angular-xmcloud] Introduce SXA layout component for angular Aug 2, 2024
@yavorsk yavorsk requested a review from a team August 2, 2024 17:44
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one last Q

…/app/routing/layout/layout.component.ts

Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
@addy-pathania addy-pathania merged commit 1ae93ce into dev Aug 7, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-3773 branch August 7, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants