Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular-xmcloud] Introduce angular SXA navigation component #1894

Merged
merged 8 commits into from
Aug 23, 2024
Merged

[angular-xmcloud] Introduce angular SXA navigation component #1894

merged 8 commits into from
Aug 23, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Aug 20, 2024

Description / Motivation

Introduce SXA Navigation component

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team August 20, 2024 14:34
addy-pathania
addy-pathania approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment otherwise looks good. 👍🏼

@yavorsk yavorsk merged commit 2843aa2 into dev Aug 23, 2024
1 check passed
@yavorsk yavorsk deleted the feature/jss-3695 branch August 23, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yavorsk @addy-pathania