[sitecore-jss] [sitecore-jss-angular] Field metadata chromes in editMode metadata #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasmaxymov
requested review from
yavorsk,
art-alexeyenko and
illiakovalenko
art-alexeyenko
requested changes
Sep 11, 2024
packages/sitecore-jss-angular/src/components/date.directive.spec.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/date.directive.spec.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/date.directive.spec.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/base-field.directive.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/base-field.directive.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/image.directive.spec.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/link.directive.spec.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/link.directive.spec.ts
Outdated
Show resolved
Hide resolved
added 2 commits
September 13, 2024 14:56
art-alexeyenko
approved these changes
Sep 13, 2024
packages/sitecore-jss-angular/src/components/base-field.directive.spec.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR enables editing support for the fields in editing mode for editMode metadata. When a field is rendered in
metadatamode it will be surrounded with open and closecodeelements with metadata content. This elements indicate location of the field and provide required metadata to enable editing in editor applications like Pages.The fields with this functionality are:
[sitecore-jss-angular] image.directive.ts
[sitecore-jss-angular] date.directive.ts
[sitecore-jss-angular] rich-text.directive.ts
[sitecore-jss-angular] text.directive.ts
[sitecore-jss-angular] link.directive.ts
[sitecore-jss-angular] router-link.directive.ts
[sitecore-jss-angular] generic-link.directive.spec.ts
Testing Details
Types of changes