[angular][xmcloud] CDP page view component #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
requested changes
Oct 24, 2024
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Outdated
Show resolved
Hide resolved
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Outdated
Show resolved
Hide resolved
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Outdated
Show resolved
Hide resolved
...tecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cloud-sdk-init.component.ts
Outdated
Show resolved
Hide resolved
...itecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cdp-page-view.component.ts
Show resolved
Hide resolved
Co-authored-by: Illia Kovalenko <23364749+illiakovalenko@users.noreply.github.com>
illiakovalenko
requested changes
Oct 25, 2024
CHANGELOG.md
Outdated
| * `[angular-xmcloud]``[sitecore-jss-angular]` Analytics and CloudSDK integration | ||
| * `[angular-xmcloud]` Add CloudSDK initialization on client side ([#1952](https://github.com/Sitecore/jss/pull/1952)) | ||
| * `[angular-xmcloud]` Add CloudSDK initialization on client side ([#1952](https://github.com/Sitecore/jss/pull/1952)) |
There was a problem hiding this comment.
This one requires migration guide as well. You can ping @art-alexeyenko to add it
packages/create-sitecore-jss/src/templates/angular-xmcloud/.env
Outdated
Show resolved
Hide resolved
Co-authored-by: Illia Kovalenko <23364749+illiakovalenko@users.noreply.github.com>
…to feature/jss-3977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Introduces CDP page view component to angular xmc app and add it to the app's scripts component by default.
It fires pageView event only in normal mode.
Testing Details
Types of changes