Make template lint use node glob to ensure consistent lint results across OS #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elyseum
changed the title
illiakovalenko
added
the
backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR updates the npm lint command to use the node glob pattern (instead of the OS glob) for scaffolded projects. This makes linting results more consistent across different OS (e.g. windows development machine vs linux build server).
See https://stackoverflow.com/questions/54165756/eslint-glob-is-not-considering-all-directories-recursively
This node glob was introduced silently in the JSS development scripts (see 786913d), but it never made its way to the scaffolding templates.
Testing Details
I experienced this with an lint issue in my (customized)
packages\create-sitecore-jss\src\templates\nextjs-sxa\src\Layout.tsxfile. The lint error was detected on Windows (**/*.tsx matches direct children), but not on Ubuntu linux (**/*.tsx does NOT match direct children).After forcing to node glob pattern, the lint issue was detected on both Windows AND (Ubuntu) linux.
Types of changes