Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[template/angular-xmcloud][template/xmcloud-proxy] Add README.md #1965

Merged
merged 12 commits into from
Nov 15, 2024
Merged

[template/angular-xmcloud][template/xmcloud-proxy] Add README.md #1965

merged 12 commits into from
Nov 15, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Nov 8, 2024 •
edited
Loading

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore

@addy-pathania addy-pathania requested a review from a team November 8, 2024 18:56
art-alexeyenko
art-alexeyenko requested changes Nov 8, 2024
View reviewed changes
packages/create-sitecore-jss/src/templates/angular-xmcloud/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular-xmcloud/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular-xmcloud/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular-xmcloud/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular-xmcloud/README.md Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/README.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/README.md Show resolved Hide resolved
art-alexeyenko
art-alexeyenko approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible job Addy, compiling it all together, thank you.

@art-alexeyenko art-alexeyenko merged commit ff6900f into dev Nov 15, 2024
1 check was pending
@art-alexeyenko art-alexeyenko deleted the feature/jss-3508-add-readme branch November 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addy-pathania @art-alexeyenko @apathania22