Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOC] Form's submission is failing. Updated @sitecore-feaas/clientside to v0.5.19. Updated @sitecore-cloudsdk to v0.4.1. #1966

Merged
merged 6 commits into from
Nov 12, 2024
Merged

[BYOC] Form's submission is failing. Updated @sitecore-feaas/clientside to v0.5.19. Updated @sitecore-cloudsdk to v0.4.1. #1966

merged 6 commits into from
Nov 12, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Nov 12, 2024 •
edited
Loading

Description / Motivation

Fixed failing Form submission. Updated @sitecore-feaas/clientside, @sitecore-cloudsdk to the latest versions

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [BYOC] Updated @sitecore-feaas/clientside to v0.5.19, passed rendering data to FEAAS.ExternalComponent [BYOC] Form's submission is failing. Updated @sitecore-feaas/clientside to v0.5.19. Passed rendering data to FEAAS.ExternalComponent. Updated @sitecore-cloudsdk to v0.4.1. Nov 12, 2024
@illiakovalenko illiakovalenko changed the title [BYOC] Form's submission is failing. Updated @sitecore-feaas/clientside to v0.5.19. Passed rendering data to FEAAS.ExternalComponent. Updated @sitecore-cloudsdk to v0.4.1. [BYOC] Form's submission is failing. Updated @sitecore-feaas/clientside to v0.5.19. Updated @sitecore-cloudsdk to v0.4.1. Nov 12, 2024
@illiakovalenko illiakovalenko requested a review from a team November 12, 2024 09:20
yavorsk
yavorsk approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@illiakovalenko illiakovalenko merged commit f4f5c58 into dev Nov 12, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the bugfix/JSS-4526 branch November 12, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @yavorsk