-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Update to nodejs v22 #1975
Conversation
…te-node-22 # Conflicts: # packages/sitecore-jss-dev-tools/package.json
…te-node-22 # Conflicts: # packages/sitecore-jss-vue/package.json # yarn.lock
...s/create-sitecore-jss/src/templates/nextjs-multisite/src/lib/middleware/plugins/multisite.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
The changes seem reasonable to me, I also verified build, lint, unit tests on my machine.
The only thing that looks off to me is the @ts-expect-error
statements. Maybe we should investigate this deeper in a separate ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this update! 👍
Please, review my comments/questions below
Description / Motivation
Update monorepo and samples to use node 22
node>=22
@types/node
deps to22.9.0
5.6.3
for compatibility@typescript-eslint
@typescript-eslint
plugin updated to version 8, some rules adjusted@stylistic/eslint-plugin-ts
dep added to keep using rules removed from@typescript-eslint
(💀 Rule deprecations: formatting rules typescript-eslint/typescript-eslint#8072)eslint
version has been bumped to 8 for compatibility. v9 introduces some breaking changes in configuration and will be upgraded to laterreact
and@types/react
versions locked to~18.2
due to some breaking changes in react types for18.3
when using node 22sinon
Known issue:
(node:8860) [DEP0040] DeprecationWarning: The
punycodemodule is deprecated. Please use a userland alternative instead.
error will pop up in console when building packages or apps. This does not affect app execution, and is caused by dependencies of dependencies JSS uses. This error will go away in time, as dependencies are updates (i.e. forhttp-proxy-middleware
Deprecation warnings when using node v22 chimurai/http-proxy-middleware#1058).Testing Details
Types of changes