Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component Library] accept dataSourceId query param #2024

Open
wants to merge 2 commits into
base: release/beta
Choose a base branch
from
Open

[Component Library] accept dataSourceId query param #2024

wants to merge 2 commits into from
+7 −6

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jan 29, 2025 •
edited
Loading

Description / Motivation

Replaces sc_datasourceId expected by render middleware before by dataSourceId query string parameter.
Also logs datasource ID by component layout service, when present.

Testing Details

  • Unit Test Adjusted
  • Manual Test/Other (Please elaborate)

Types of changes

  • [?] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 29, 2025 21:43
yavorsk
yavorsk requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
just have a look at yarn install check failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @yavorsk