[Focused Improvements] Hidden renderings do not have implementation and result in console error message #834
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/6cTR63mVMhS6cDXTMCkGWTdbzGwJ [Deployment for e0c620e failed] |
There was a problem hiding this comment.
Looks good, just a couple minor things. In general though, I'm wondering if we couldn't have taken a similar approach as we do with Missing Component (injected directly in the framework Placeholder component implementations w/ allowed override if needed)? This approach wouldn't require any change in the samples / component factories.
| import { Component } from '@angular/core'; | ||
| @Component({ | ||
| selector: 'sc-hidden-rendering', | ||
| host: { |
There was a problem hiding this comment.
Why the decision to use host here instead of template (like missing-component.component.ts)?
There was a problem hiding this comment.
Because, we need to style wrapper (host means sc-hidden-rendering tag), in case if I will add template and style it, EE chromes will not be rendered correctly
|
@ambrauer HiddenRendering component is the same component as others, and missing component rendered if no component is found. In this case it means that we will need to directly check: Hidden Rendering data doesn't have difference if compare with other components |
Description / Motivation
[Focused Improvements] Hidden renderings do not have implementation and result in console error message
HiddenRenderingscomponent will be rendered in case if rendering hidden by personalizationAdded
packagesto component factories, it allows us to import multiple components from the single packageTesting Details
Types of changes
/docsdirectory)