Update dependencies (#39)

* Update Puppeteer

* Update Cypress

* Enable Cypress tests

* Add Puppeteer only workflow

* Remove unused file

* Update Alfa and React

* Remove verbatimModuleSyntax option

* Workaround missing crypto in JSDOM

* Fix enzyme loading cheerio

* Update Alfa

* Re-enable persister

* Update name

* Update to node 20, 22 (remove node 18 due to crypto)

.github/workflows/integrate.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18, 20]
+        node-version: [20, 22]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4

.github/workflows/puppeteer.yml

@@ -0,0 +1,41 @@
+name: Puppeteer tests
+
+# We've experienced quite a lot of instability with the puppeteer setup, notably
+# the fact that it works locally but not in the Github action. Thus, we've removed
+# it from the main integrate workflow, which in turns means we do not have a nice
+# way to try and fix it.
+
+# This workflow only runs the puppeteer tests, and MUST NOT be required as a branch
+# protection. It will nonetheless let us monitor the status of it and make it easier
+# for us to fix the problems once we get to it.
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - "*"
+jobs:
+  build:
+    name: Build (puppeteer)
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [20, 22]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+      - uses: actions/cache@v4
+        with:
+          path: .yarn/cache
+          key: yarn-${{ hashFiles('yarn.lock') }}
+      - run: >
+          yarn config set
+          npmScopes.siteimprove.npmAuthToken
+          ${{ secrets.GITHUB_TOKEN }}
+      - run: yarn install --immutable
+      - run: yarn build
+      - run: yarn workspace end-to-end-testing-puppeteer test

common/package.json

@@ -11,14 +11,14 @@
     "./persist.js": "./persist.js"
   },
   "devDependencies": {
-    "@siteimprove/alfa-act": "^0.81.0",
-    "@siteimprove/alfa-assert": "^0.65.2",
-    "@siteimprove/alfa-formatter": "^0.65.2",
-    "@siteimprove/alfa-hash": "^0.81.0",
-    "@siteimprove/alfa-mapper": "^0.81.0"
+    "@siteimprove/alfa-act": "^0.90.1",
+    "@siteimprove/alfa-assert": "^0.71.1",
+    "@siteimprove/alfa-formatter": "^0.71.1",
+    "@siteimprove/alfa-hash": "^0.90.1",
+    "@siteimprove/alfa-mapper": "^0.90.1"
   },
   "dependencies": {
-    "@siteimprove/alfa-formatter-earl": "^0.65.2",
-    "@siteimprove/alfa-future": "^0.81.0"
+    "@siteimprove/alfa-formatter-earl": "^0.71.1",
+    "@siteimprove/alfa-future": "^0.90.1"
   }
 }

common/persist.ts

@@ -13,7 +13,7 @@ import * as path from "path";
 
 export function persist<I, T extends Hashable, Q extends Question.Metadata, S>(
   output: Mapper<I, string>,
-  format: Formatter<I, T, Q, S> = earl.default()
+  format: Formatter<I, T, Q, S> = earl()
 ): Handler<I, T, Q, S> {
   return (input, rules, outcomes, message) =>
     Future.from(async () => {

custom-testing/adding-rules/package.json

@@ -10,15 +10,15 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-act": "^0.81.0",
-    "@siteimprove/alfa-chai": "^0.65.2",
-    "@siteimprove/alfa-dom": "^0.81.0",
-    "@siteimprove/alfa-future": "^0.81.0",
-    "@siteimprove/alfa-playwright": "^0.65.2",
-    "@siteimprove/alfa-refinement": "^0.81.0",
-    "@siteimprove/alfa-result": "^0.81.0",
-    "@siteimprove/alfa-rules": "^0.81.0",
-    "@siteimprove/alfa-web": "^0.81.0",
+    "@siteimprove/alfa-act": "^0.90.1",
+    "@siteimprove/alfa-chai": "^0.71.1",
+    "@siteimprove/alfa-dom": "^0.90.1",
+    "@siteimprove/alfa-future": "^0.90.1",
+    "@siteimprove/alfa-playwright": "^0.71.1",
+    "@siteimprove/alfa-refinement": "^0.90.1",
+    "@siteimprove/alfa-result": "^0.90.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
+    "@siteimprove/alfa-web": "^0.90.1",
     "@types/chai": "^4.2.3",
     "@types/mocha": "^5.2.7",
     "chai": "^4.3.4",

custom-testing/adding-rules/test/page.spec.ts

@@ -62,7 +62,7 @@ const myRule = Rule.Atomic.of<Page, Element>({
 });
 
 // adding myRule to the default ruleset
-const allRules = rules.default.append(myRule);
+const allRules = rules.append(myRule);
 
 // Creating a Chai plugin which runs all rules (default and custom).
 chai.use(

custom-testing/answering/package.json

@@ -10,16 +10,16 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-act": "^0.81.0",
-    "@siteimprove/alfa-chai": "^0.65.2",
-    "@siteimprove/alfa-css": "^0.81.0",
-    "@siteimprove/alfa-dom": "^0.81.0",
-    "@siteimprove/alfa-future": "^0.81.0",
-    "@siteimprove/alfa-hash": "^0.81.0",
-    "@siteimprove/alfa-option": "^0.81.0",
-    "@siteimprove/alfa-playwright": "^0.65.2",
-    "@siteimprove/alfa-refinement": "^0.81.0",
-    "@siteimprove/alfa-rules": "^0.81.0",
+    "@siteimprove/alfa-act": "^0.90.1",
+    "@siteimprove/alfa-chai": "^0.71.1",
+    "@siteimprove/alfa-css": "^0.90.1",
+    "@siteimprove/alfa-dom": "^0.90.1",
+    "@siteimprove/alfa-future": "^0.90.1",
+    "@siteimprove/alfa-hash": "^0.90.1",
+    "@siteimprove/alfa-option": "^0.90.1",
+    "@siteimprove/alfa-playwright": "^0.71.1",
+    "@siteimprove/alfa-refinement": "^0.90.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
     "@types/chai": "^4.2.3",
     "@types/mocha": "^5.2.7",
     "chai": "^4.3.4",

custom-testing/answering/test/answering.spec.ts

@@ -26,7 +26,7 @@ const { and } = Refinement;
 chai.use(
   alfa.Chai.createPlugin(
     (value: Playwright.Type) => Future.from(Playwright.toPage(value)),
-    rules.default.filter((rule) => !rule.uri.includes("r111")),
+    rules.filter((rule) => !rule.uri.includes("r111")),
     [persist(() => "test/outcomes/page.spec.json")]
   )
 );
@@ -116,8 +116,8 @@ function oracle<I, T extends Hashable, S>(
  * page.
  */
 describe("page.html", () => {
-  beforeEach(setup);
-  afterEach(teardown);
+  before(setup);
+  after(teardown);
 
   // By default, only Failed outcomes are considered
   it("should not have any Failed outcome", async () => {

custom-testing/crawling/crawling.ts

@@ -25,7 +25,7 @@ const frontier = Frontier.of(scope, [scope, ...seed]);
 Crawler.with(async (crawler) => {
   for await (const result of crawler.crawl(frontier)) {
     for (const input of result) {
-      const outcomes = await Audit.of(input, rules.default)
+      const outcomes = await Audit.of(input, rules)
         .evaluate()
         .map((outcomes) => [...outcomes]);
 

custom-testing/crawling/package.json

@@ -10,10 +10,10 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-act": "^0.81.0",
-    "@siteimprove/alfa-crawler": "^0.65.2",
-    "@siteimprove/alfa-frontier": "^0.65.2",
-    "@siteimprove/alfa-hash": "^0.81.0",
-    "@siteimprove/alfa-rules": "^0.81.0"
+    "@siteimprove/alfa-act": "^0.90.1",
+    "@siteimprove/alfa-crawler": "^0.71.1",
+    "@siteimprove/alfa-frontier": "^0.71.1",
+    "@siteimprove/alfa-hash": "^0.90.1",
+    "@siteimprove/alfa-rules": "^0.90.1"
   }
 }

custom-testing/filtering/package.json

@@ -10,15 +10,15 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-act": "^0.81.0",
-    "@siteimprove/alfa-chai": "^0.65.2",
-    "@siteimprove/alfa-future": "^0.81.0",
-    "@siteimprove/alfa-hash": "^0.81.0",
-    "@siteimprove/alfa-iterable": "^0.81.0",
-    "@siteimprove/alfa-playwright": "^0.65.2",
-    "@siteimprove/alfa-refinement": "^0.81.0",
-    "@siteimprove/alfa-rules": "^0.81.0",
-    "@siteimprove/alfa-wcag": "^0.81.0",
+    "@siteimprove/alfa-act": "^0.90.1",
+    "@siteimprove/alfa-chai": "^0.71.1",
+    "@siteimprove/alfa-future": "^0.90.1",
+    "@siteimprove/alfa-hash": "^0.90.1",
+    "@siteimprove/alfa-iterable": "^0.90.1",
+    "@siteimprove/alfa-playwright": "^0.71.1",
+    "@siteimprove/alfa-refinement": "^0.90.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
+    "@siteimprove/alfa-wcag": "^0.90.1",
     "@types/chai": "^4.2.3",
     "@types/mocha": "^5.2.7",
     "chai": "^4.3.4",

custom-testing/filtering/test/filtering.spec.ts

@@ -26,7 +26,7 @@ const { and } = Refinement;
 chai.use(
   alfa.Chai.createPlugin(
     (value: Playwright.Type) => Future.from(Playwright.toPage(value)),
-    rules.default.filter((rule) => !rule.uri.includes("r111")),
+    rules.filter((rule) => !rule.uri.includes("r111")),
     [persist(() => "test/outcomes/filtering.spec.json")]
   )
 );

custom-testing/interacting/package.json

@@ -10,10 +10,10 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-chai": "^0.65.2",
-    "@siteimprove/alfa-future": "^0.81.0",
-    "@siteimprove/alfa-playwright": "^0.65.2",
-    "@siteimprove/alfa-rules": "^0.81.0",
+    "@siteimprove/alfa-chai": "^0.71.1",
+    "@siteimprove/alfa-future": "^0.90.1",
+    "@siteimprove/alfa-playwright": "^0.71.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
     "@types/chai": "^4.2.3",
     "@types/mocha": "^5.2.7",
     "chai": "^4.3.4",

custom-testing/measuring-performances/package.json

@@ -10,11 +10,11 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-act": "^0.81.0",
-    "@siteimprove/alfa-aria": "^0.81.0",
-    "@siteimprove/alfa-cascade": "^0.81.0",
-    "@siteimprove/alfa-performance": "^0.81.0",
-    "@siteimprove/alfa-rules": "^0.81.0",
-    "@siteimprove/alfa-scraper": "^0.65.2"
+    "@siteimprove/alfa-act": "^0.90.1",
+    "@siteimprove/alfa-aria": "^0.90.1",
+    "@siteimprove/alfa-cascade": "^0.90.1",
+    "@siteimprove/alfa-performance": "^0.90.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
+    "@siteimprove/alfa-scraper": "^0.71.1"
   }
 }

custom-testing/measuring-performances/performance.ts

@@ -101,7 +101,7 @@ Scraper.with(async (scraper) => {
 
     // The Performance object with its callback listener is passed to the Audit
     // evaluation.
-    await Audit.of(page, rules.default).evaluate(rulesPerformance);
+    await Audit.of(page, rules).evaluate(rulesPerformance);
 
     // Closing the total duration measurement.
     commonPerformance.measure("total", start);

custom-testing/navigating/package.json

@@ -10,10 +10,10 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-chai": "^0.65.2",
-    "@siteimprove/alfa-future": "^0.81.0",
-    "@siteimprove/alfa-playwright": "^0.65.2",
-    "@siteimprove/alfa-rules": "^0.81.0",
+    "@siteimprove/alfa-chai": "^0.71.1",
+    "@siteimprove/alfa-future": "^0.90.1",
+    "@siteimprove/alfa-playwright": "^0.71.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
     "@types/chai": "^4.2.3",
     "@types/mocha": "^5.2.7",
     "chai": "^4.3.4",

custom-testing/scraping/package.json

@@ -10,9 +10,9 @@
     "test": "node scraping.js"
   },
   "devDependencies": {
-    "@siteimprove/alfa-act": "^0.81.0",
-    "@siteimprove/alfa-hash": "^0.81.0",
-    "@siteimprove/alfa-rules": "^0.81.0",
-    "@siteimprove/alfa-scraper": "^0.65.2"
+    "@siteimprove/alfa-act": "^0.90.1",
+    "@siteimprove/alfa-hash": "^0.90.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
+    "@siteimprove/alfa-scraper": "^0.71.1"
   }
 }

custom-testing/scraping/scraping.ts

@@ -29,7 +29,7 @@ Scraper.with(async (scraper) => {
   }
 
   for (const input of alfaPage) {
-    const outcomes = await Audit.of(input, rules.default)
+    const outcomes = await Audit.of(input, rules)
       .evaluate()
       .map((outcomes) => [...outcomes]);
 

end-to-end-testing/cypress/.gitignore

@@ -1,2 +1 @@
-videos
-screenshots
+!cypress.config.js

end-to-end-testing/cypress/cypress.config.js

@@ -0,0 +1,15 @@
+import { defineConfig } from "cypress";
+
+export default defineConfig({
+  fixturesFolder: "fixtures",
+  screenshotsFolder: "screenshots",
+  videosFolder: "videos",
+
+  e2e: {
+    setupNodeEvents(on, config) {
+      // implement node event listeners here
+    },
+    supportFile: "support.js",
+    specPattern: "test/**.spec.js",
+  },
+});

end-to-end-testing/cypress/package.json

@@ -10,8 +10,8 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-cypress": "^0.65.2",
-    "@siteimprove/alfa-rules": "^0.81.0",
-    "cypress": "^7.0.1"
+    "@siteimprove/alfa-cypress": "^0.71.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
+    "cypress": "^13.3.1"
   }
 }

end-to-end-testing/cypress/support.ts

@@ -3,7 +3,7 @@ import { Cypress } from "@siteimprove/alfa-cypress";
 import rules from "@siteimprove/alfa-rules";
 
 chai.use(
-  Cypress.createPlugin(rules.default, [
+  Cypress.createPlugin(rules, [
     Cypress.Handler.persist(() => "outcomes/page.spec.json"),
   ])
 );

end-to-end-testing/playwright/package.json

@@ -10,10 +10,10 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-chai": "^0.65.2",
-    "@siteimprove/alfa-future": "^0.81.0",
-    "@siteimprove/alfa-playwright": "^0.65.2",
-    "@siteimprove/alfa-rules": "^0.81.0",
+    "@siteimprove/alfa-chai": "^0.71.1",
+    "@siteimprove/alfa-future": "^0.90.1",
+    "@siteimprove/alfa-playwright": "^0.71.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
     "@types/chai": "^4.2.3",
     "@types/mocha": "^5.2.7",
     "chai": "^4.3.4",

end-to-end-testing/playwright/test/page.spec.ts

@@ -22,7 +22,7 @@ const __dirname = path.dirname(__filename);
 chai.use(
   alfa.Chai.createPlugin(
     (value: Playwright.Type) => Future.from(Playwright.toPage(value)),
-    rules.default.filter((rule) => !rule.uri.includes("r111")),
+    rules.filter((rule) => !rule.uri.includes("r111")),
     [persist(() => "test/outcomes/page.spec.json")]
   )
 );

end-to-end-testing/puppeteer/package.json

@@ -10,15 +10,15 @@
     "node": ">=20.0.0"
   },
   "devDependencies": {
-    "@siteimprove/alfa-chai": "^0.65.2",
-    "@siteimprove/alfa-future": "^0.81.0",
-    "@siteimprove/alfa-puppeteer": "^0.65.2",
-    "@siteimprove/alfa-rules": "^0.81.0",
+    "@siteimprove/alfa-chai": "^0.71.1",
+    "@siteimprove/alfa-future": "^0.90.1",
+    "@siteimprove/alfa-puppeteer": "^0.71.1",
+    "@siteimprove/alfa-rules": "^0.90.1",
     "@types/chai": "^4.2.3",
     "@types/mocha": "^5.2.7",
     "chai": "^4.3.4",
     "common": "workspace:^",
     "mocha": "^8.3.2",
-    "puppeteer": "^8.0.0"
+    "puppeteer": "^22.14.0"
   }
 }