Audit from alfa-act & input directly from Puppeteer - possible?

[BogdanCerovac]

Hi,

trying https://github.com/Siteimprove/alfa-examples/blob/main/end-to-end-testing/puppeteer/test/page.spec.ts

and am wondering if we can maybe use audit directly on Puppeteers page/content?

So by not using chai and mocha, but passing Puppeteer content (page / raw HTML) directly to Audit (input)?

For example:

(async () => {
  const browser = await puppeteer.launch();
  const page = await browser.newPage();
  await page.goto('https://example.com');
  // await page.screenshot({ path: 'example.png' });
  const pageContStr = await page.content();
  /* probably some transformation from string to json */
  const outcomes = await Audit.of(pageContJson, rules).evaluate();
  
  await browser.close();
})();

[kasperisager]

Hi there! You can absolutely do that, yes:

import { Puppeteer } from "@siteimprove/alfa-puppeteer";

const browser = await puppeteer.launch();
const page = await browser.newPage();
await page.goto('https://example.com');

const handle = await page.evaluateHandle(() => window.document);

const outcomes = await Audit.of(await Puppeteer.toPage(handle), rules).evaluate();
  
await browser.close();

In fact, the Puppeteer example you linked does effectively the same thing right here: https://github.com/Siteimprove/alfa-examples/blob/ead4b79932f33135df718ef20d43e0e0f69203af/end-to-end-testing/puppeteer/test/page.spec.ts#L15

[kasperisager]

That's odd. Running your code as-is works fine on my end. Which version of Alfa have you installed (npm why @siteimprove/alfa-rules)?

[BogdanCerovac]

I took 0.10.0 for all packages;

D:\NodeProj\PoC-CraWWWler>npm why @siteimprove/alfa-rules
@siteimprove/alfa-rules@0.10.0
node_modules/@siteimprove/alfa-rules
  @siteimprove/alfa-rules@"^0.10.0" from the root project

[kasperisager]

Could you check if you get the same result with v0.12.0?

[BogdanCerovac]

Nice, I can confirm that it works with v0.12.0. Thank you!

[kasperisager]

Wonderful, my pleasure!