Improve testability #105
Improve testability #105
Conversation
Allow test for files in scripts folder Make `yarn start`: - test specification for changed file - reprocess failed files on new update
There was a problem hiding this comment.
Good suggestions! As for introducing tests for the build scripts, there's of course a bit a chicken/egg situation going on: Tests are written using @siteimprove/alfa-test which requires the build system to build. As such, the build system cannot make use of this package, nor can the build system even contain TypeScript files. What I'd much rather have us do is introduce inline assertions in the build system in lieu of separate tests.
| * | ||
| * @type {Array<string>} | ||
| */ | ||
| let failed = []; |
There was a problem hiding this comment.
While I do see the point of introducing something like this, I'm also a bit concerned of the impact it will have. I for one would very much dislike having my feedback stream littered with errors I already know exist because I've seen them previously. If I make a change to file A and compilation fails because I also need to change something in file B, I don't want to be reminded that file A fails every time I write to file B. Once I'm finished with file B I'll head back and check for myself if file A still fails. In the event that I forgot to do so and it still fails, CI will remind me in the worst case.
There was a problem hiding this comment.
To clarify, I'd actually love to be reminded about file A, I just don't want to see a bunch of errors unrelated to file B if that's the file I'm writing to.
Allow test for files in scripts folder
Make
yarn start: