Lower typescript target to es2019 from es2020 #1283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue is simililar to this scottohara/loot#185 It isn't directly an issue with alfa-cypress, but a compatibility issue with cypress |
|
This should have been fixed in Cypress 13: cypress-io/cypress#27438 |
|
Updating Cypress to version 13 resolves the problem as they now accept more modern ES syntax. Closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alfa-cypress was causing errors due to nullish coalescing operator (??).
By lowering the typescript build target to es2019, the issue goes away.
Was able to test it locally, by cloning and building alfa with the lowered build target, and then copy the files to my cypress project.
The first instance of the error is thrown from alfa-css
src/value.js.It is therefor not enough to just lower the build target for just alfa-cypress.
Is there any danger for other projects in lowering the build target to es2019?