Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Flattened type #1376

Merged
merged 17 commits into from
Mar 17, 2023
Merged

Improve Flattened type #1376

merged 17 commits into from
Mar 17, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Mar 15, 2023

Part of #1037

  • Add an alfa-act/Question.Metadata type that captures the expected shape of Metadata. Given that the shape is already enforced in the Oracle type, this ensures it at rule building time.
  • Fix the inference of Input, Target, and Subject types in the Flattened export.
  • Update TypeScript. We're currently locked out of 4.9 because of Expression produces a union type that is too complex to represent microsoft/TypeScript#53234 😞
  • Add some type annotations in some import statements.
  • Default empty question metadata to {} rather than never, this avoids never creeping in some weird places.
  • Rules asking no questions now accept anything as oracle… since they'll never call it…

@Jym77 Jym77 self-assigned this Mar 15, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Mar 15, 2023
@Jym77 Jym77 marked this pull request as ready for review March 15, 2023 15:01
@Jym77 Jym77 requested review from a team and rcj-siteimprove March 15, 2023 15:01
@Jym77 Jym77 added this pull request to the merge queue Mar 17, 2023
Merged via the queue into main with commit 584d685 Mar 17, 2023
@Jym77 Jym77 deleted the improve-flattened-type branch March 17, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants