Improve Clickable Region Computation for R111 and R113 #1761
+707
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7eaf006 The changes in this PR will be included in the next version bump. This PR includes changesets to release 80 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rcj-siteimprove
added
the
minor
|
!pr extract |
rcj-siteimprove
changed the title
Rectangles
rcj-siteimprove
force-pushed
the
subtract-rectangles
branch
from
b3d664a to
81fbb0f
Compare
|
!pr extract |
* In painting order computation, `isRendered` has been replaced by the stricter `isVisible` predicate when determining which elements are painted. * `Rectangle.subtract` now accepts one or more rectangles to subtract. * `getClickableRegion` no longer returns a `Result` since it was used to indicate the absense of a clickable region, which can be achieved better with an empty `Sequence`.
|
!pr extract |
Jym77
approved these changes
Mar 12, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
* Add method for subtracting rectangles * Add changeset * Add reference * Extract API * Use painting order to determine the clickable region of an element * Add references * Consider non-descendants and descendant targets when comuting clickable region * Add changeset * Add changeset * Use `isTarget` in clickable region computation * Sort imports * Clean up * Extract API * Address review comments and fix issues * In painting order computation, `isRendered` has been replaced by the stricter `isVisible` predicate when determining which elements are painted. * `Rectangle.subtract` now accepts one or more rectangles to subtract. * `getClickableRegion` no longer returns a `Result` since it was used to indicate the absense of a clickable region, which can be achieved better with an empty `Sequence`. * Extract API --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements using the new
PaintingOrderto get a better representation of the clickable region of an element by repeatedly subtracting the bounding boxes of elements on top of the target element resulting in a region of constituent boxes.