Rework audit interviewers for CLI #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
added
the
major
* master: Update changelog Add missing requirement to R21 Internal optimisations to reduce allocations Split out property test cases Adjust test cases Internal cleanup of style properties Make R74 and R75 inapplicable to 0-dimension font sizes SIA R7 ignore invisible text and fully overwritten attributes (#675) Disable Dependabot for now Upgrade to Yarn Berry (#258) Bump webdriverio from 6.12.1 to 7.0.1 (#700) Add user agent styles for form controls Switch to native Node.js source map support (#267) Bump @angular/core from 11.1.2 to 11.2.0 (#705) Bump typescript from 4.1.4 to 4.1.5 (#704) Bump @types/chai from 4.2.14 to 4.2.15 (#703) Add missing package references Add missing package references
* master: (35 commits) Add additional `Comparable` functions Require that keys be object types in `Cache<K, V>` Add some whitespace to `Command` output Avoid some branch misses in `SelectorMap.from()` Use plain `Map` for CLI answers Add additional and deprecate some existing `Parser` functions Internal alignment Add additional collection methods Align `Array` and `Iterable` functions Correct return type of `Array.filter()` and `Array.reject()` Treat `aria-hidden` as case-insensitive Use a plain `Map` for cached computed properties Use JSON for `Node` and `Name` test cases Update Contributor Covenant to 2.0 Support legacy `display` values Configure labels Bump actions/cache from v1 to v2.1.4 (#720) Bump actions/setup-node from v1 to v2.1.4 (#719) Enable updates for actions Update build instructions ...
* master: Update @types/node
* master: Update all dependencies
Jym77
previously approved these changes
Feb 23, 2021
* master: `NODE_AUTH_TOKEN` -> `GITHUB_TOKEN` Use `NODE_AUTH_TOKEN` for registry authentication v0.11.0 Add scripts for handling release tasks Update release workflow Update lockfile Upgrade to Yarn `master` Add version ranges to workspace references Add missing plugin Use `workspace:` protocol for local package references Remove Lerna and disable publish Revert "v0.11.0" Add missing release heading v0.11.0 Update changelog Additional allocation reductions Allow self-referencing `aria-labelledby` Bump actions/setup-node from v2.1.4 to v2.1.5 (#721)
Jym77
previously approved these changes
Feb 24, 2021
kasperisager
added a commit
that referenced
this pull request
Feb 24, 2021
* master: (75 commits) Rework audit interviewers for CLI (#699) Rework `Hash` as an abstract class (#670) `NODE_AUTH_TOKEN` -> `GITHUB_TOKEN` Use `NODE_AUTH_TOKEN` for registry authentication v0.11.0 Add scripts for handling release tasks Update release workflow Update lockfile Upgrade to Yarn `master` Add version ranges to workspace references Add missing plugin Use `workspace:` protocol for local package references Remove Lerna and disable publish Revert "v0.11.0" Add missing release heading v0.11.0 Update changelog Additional allocation reductions Allow self-referencing `aria-labelledby` Bump actions/setup-node from v2.1.4 to v2.1.5 (#721) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #255.
Currently mostly exploratory to figure out the direction we want to take this.
The plan so far is to provide a single core interviewer,@siteimprove/alfa-interviewer-console, that functions similarly to the current--interactivemode of the CLI, but implemented using https://github.com/vadimdemedes/ink instead.On second thought, this pull request will only solve the first part of the puzzle; making interviewers external to the CLI. We will not implement a core interviewer just yet as this will be a significant undertaking. I'll branch off the current console interviewer for later use. This means that, for now, the CLI is limited to custom interviewers, which is still a massive improvement over the partial implementation of the current
--interactivemode:alfa audit --interviewer ./interviewer.js https://example.com