Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringIndex and GraphemeIndex to GlyphBounds #396

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

gerdus
Copy link
Contributor

@gerdus gerdus commented Mar 17, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Add StringIndex and GraphemeIndex to GlyphBounds to enable hit testing glyphs and get the string index.

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2024

CLA assistant check
All committers have signed the CLA.

@gerdus
Copy link
Contributor Author

gerdus commented Mar 17, 2024

ref discussion: #386

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86%. Comparing base (15b7f8e) to head (5cfb1fd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #396   +/-   ##
=====================================
  Coverage     86%     86%           
=====================================
  Files        238     238           
  Lines      15229   15251   +22     
  Branches    2108    2108           
=====================================
+ Hits       13189   13219   +30     
+ Misses      1566    1561    -5     
+ Partials     474     471    -3     
Flag Coverage Δ
unittests 86% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks!

@JimBobSquarePants JimBobSquarePants merged commit 0b60d5a into SixLabors:main Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants