Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DoShaping Option #399

Closed
wants to merge 1 commit into from
Closed

Add DoShaping Option #399

wants to merge 1 commit into from

Conversation

gerdus
Copy link
Contributor

@gerdus gerdus commented Apr 14, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Add option to TextOptions to skip shaping since it's a large percentage of the text layout.
In my case it increased the FPS of my text stress test from a middling 6 FPS to an incredible 10 FPS, the hot path now being almost completely rending.
Feel free to reject if you don't think it would be useful or would complicate support.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86%. Comparing base (91405e3) to head (ca9ed62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #399   +/-   ##
=====================================
  Coverage     86%     86%           
=====================================
  Files        238     239    +1     
  Lines      15255   15264    +9     
  Branches    2108    2109    +1     
=====================================
+ Hits       13234   13243    +9     
  Misses      1550    1550           
  Partials     471     471           
Flag Coverage Δ
unittests 86% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerdus gerdus closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant