Lock free Read/Write Identical Request Implementation

[deanmarcussen]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
• I have provided test coverage for my change (where applicable)

Description

Proposes replacing the AsyncKeyLock with an implementation based around ConcurrentDictionary.

Note: I have not removed the AsyncKeyLock code or related test code.

Test coverage from the Integration Tests.

[JimBobSquarePants]

Awesome, thanks!

[cristipufu]

@deanmarcussen @JimBobSquarePants can you guys please provide more details about this change? How is it better (pros/cons) vs the previous implementation with the AsyncLock?

[JimBobSquarePants]

It’s about 30x faster as I recall from the load test benchmarks

[sebastienros]

To be precise, under stress it went from 2K RPS to 60K RPS, which was the static file middleware raw perf.

[deanmarcussen]

Worth having a read of the full pr from @JimBobSquarePants #121 where the bottlenecks in the existing lock where identified and we tested the lock free approach

[cristipufu]

Thanks a lot guys!