Is it necessary to open console windows in run-tests?

[jongleur1983]

Prerequisites

• I have written a descriptive issue title
• I have verified that I am running the latest version of ImageSharp
• I have verified if the problem exist in both DEBUG and RELEASE mode
• I have searched open and closed issues to ensure it has not already been reported

Description

the run-tests.ps1 script is used to run the unit tests.
When I run it from a powershell console window (on Windows10) repeatingly other windows pop up for some fraction of a second. These windows look like cmd console windows or similar, but I'm not sure as they close immediately.

My issue with that is: While tests are running I often would like to do other stuff in parallel, but those flashing windows not only are visually disturbing, they steal the keyboard input focus as well.

I'm not sure where they're originating, but it would be great if we could either hide them or get them opening in background instead.

Steps to Reproduce

• open PowerShell
• build ImageSharp
• run tests (I used net471 as framework)

System Configuration

• ImageSharp version: current master branch
• Other ImageSharp packages and versions:
• Environment (Operating system, version and so on): Windows10, fresh April Update
• .NET Framework version:
• Additional information:

[antonfirsov]

It is dump-jpeg-coeffs.exe being executed by Process.Start(). Do you know a better way of executing a command line utility from managed code?

[jongleur1983]

thanks.
according to https://stackoverflow.com/questions/5377423/hide-console-window-from-process-start-c-sharp it's possible to customize the ProcessStartInfo.
Not that clear from the text itself, but might be a good starting point. Perhaps I'll have a look at it, if no one else takes it.

[jongleur1983]

works.
I'm on another branch currently, but the following is working for me:
I replaced

var process = Process.Start(DumpToolFullPath, args); process.WaitForExit();

by

var process = new Process
  {
    StartInfo =
      {
        UseShellExecute = true,
        CreateNoWindow = true,
        WindowStyle = ProcessWindowStyle.Hidden,
        FileName = DumpToolFullPath,
        Arguments = args,
        RedirectStandardOutput = false
      }
  };
process.Start();
process.WaitForExit();`

[antonfirsov]

@jongleur1983 great, thanks for the investigation!

Do you want to PR it, or would you rather leave it to us?

[jongleur1983]

as you like. I didn't want to change branches yesterday to commit that change on a separate PR, but if nobody else takes this before I'll do a PR within this week, I think.

[antonfirsov]

Fixed in #561