Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a new ImageSharp NuGet package which contains the image comparison utility classes #794

Open
matt-psaltis opened this issue Dec 19, 2018 · 1 comment
Open

Provide a new ImageSharp NuGet package which contains the image comparison utility classes #794

matt-psaltis opened this issue Dec 19, 2018 · 1 comment
Labels
area:build
Milestone
Future

Comments

@matt-psaltis
Copy link

To support visual regression testing, I am requesting a new feature.

ImageSharp already contains Image comparison in the Test namespace located here:
https://github.com/SixLabors/ImageSharp/tree/master/tests/ImageSharp.Tests/TestUtilities/ImageComparison

These methods call internal methods in the main ImageSharp library and so I'm currently resorting to reflection to do this.

Could these be moved to a separate NuGet library for public consumption?
@antonfirsov
Copy link
Member

@SaltyDH cool that you are interested in this! :)

Unfortunately, these classes are kinda messy, and need a lot of refactor before making them public. We can only take care of this past 1.0.

@antonfirsov antonfirsov added this to the Future milestone Dec 29, 2018
brickman1444 added a commit to brickman1444/AntiqueAppraisalBot that referenced this issue Dec 30, 2019
@brickman1444
Get a real acceptance test working for composed images
90c2194 
-Pull out the random instantiation to a higher level function so it can be passed in from the testing code
-Implement an image comparison utility because that isn't provided by ImageSharp yet. See SixLabors/ImageSharp#794. Implementation based on https://github.com/SixLabors/ImageSharp/blob/9ab02b6ee67b25fd3653146c069dab3687fc0ac8/tests/ImageSharp.Tests/TestUtilities/ImageComparison/TolerantImageComparer.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:build
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@JimBobSquarePants @matt-psaltis @antonfirsov