Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JpegDecoderTests.Decode_IsCancellable #1415

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #1414 (hopefully)

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1415 (73454f5) into master (adf56a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1415   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         692      692           
  Lines       31189    31189           
  Branches     3578     3578           
=======================================
  Hits        25884    25884           
  Misses       4582     4582           
  Partials      723      723           
Flag Coverage Δ
unittests 82.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf56a4...73454f5. Read the comment docs.

@JimBobSquarePants
Copy link
Member

This looks like it works so I'm merging it. I've had to retrigger the build a lot recently!

@JimBobSquarePants JimBobSquarePants added this to the 1.1.0 milestone Nov 6, 2020
@JimBobSquarePants JimBobSquarePants merged commit cf9cc6b into master Nov 6, 2020
@JimBobSquarePants JimBobSquarePants deleted the af/fix-Decode_IsCancellable branch November 6, 2020 20:32
JimBobSquarePants added a commit that referenced this pull request Mar 13, 2021
Fix JpegDecoderTests.Decode_IsCancellable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JpegDecoderTests.Decode_IsCancellable is flaky on CI
2 participants